Add basic link support to AppKit/macOS formatting bar #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for hyperlinking in the formatting bar on macOS (AppKit only for now).
What’s included:
• A link button was added to the existing toggle group in the formatting bar.
• CMD+K keyboard shortcut is now hooked up to trigger the link action.
• Clicking the button opens a sheet if the selected text does not already contain a link, allowing users to insert a URL.
• If the selected text already contains a link, the toggle is highlighted and clicking it will remove the link.
What’s not included:
• No support yet for internal links (could be added later).
• No ability to insert a link without selecting text first.
Open to suggestions for a better UI placement or UX improvements for the link feature.