Skip to content

fix: ability to set an existing secret on the helm chart #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ability to set an existing secret on the helm chart #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/kafka-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
appVersion: "1.0"
description: A Helm chart for Kubernetes
name: kafka-exporter
version: 1.2.0
version: 1.2.1
home: https://github.com/abhishekjiitr/kafka-exporter-helm
maintainers:
- name: abhishekjiitr
Expand Down
9 changes: 8 additions & 1 deletion charts/kafka-exporter/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
"metrics": {{ .Values.datadog.metrics | toJson | nindent 16 -}}
}
]
{{- end }}
{{- end }}
labels:
app.kubernetes.io/name: {{ include "kafka-exporter.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
Expand All @@ -44,6 +44,11 @@ spec:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- if .Values.kafkaExporter.sasl.existingSecret }}
envFrom:
- secretRef:
name: {{ .Values.kafkaExporter.sasl.existingSecret }}
{{- end }}
args:
{{- if .Values.kafkaExporter}}
{{- range .Values.kafkaExporter.kafka.servers }}
Expand All @@ -59,7 +64,9 @@ spec:
- --sasl.handshake=false
{{- end }}
- --sasl.username={{ .Values.kafkaExporter.sasl.username }}
{{- if eq .Values.kafkaExporter.sasl.existingSecret "" }}
- --sasl.password={{ .Values.kafkaExporter.sasl.password }}
{{- end }}
- --sasl.mechanism={{ .Values.kafkaExporter.sasl.mechanism }}
{{- end }}
{{- if .Values.kafkaExporter.tls.enabled}}
Expand Down
1 change: 1 addition & 0 deletions charts/kafka-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ kafkaExporter:
handshake: true
username: ""
password: ""
existingSecret: "" # has the password stored in it. If set, will override password
mechanism: ""

tls:
Expand Down