Skip to content

Fixing wrapping with server prefix docs if you have servers in config #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

teplinsky-maxim
Copy link

No description provided.

@teplinsky-maxim
Copy link
Author

fixes #780

@danielgtaylor danielgtaylor requested a review from Copilot March 29, 2025 17:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the issue with wrapping server prefix documentation routes by introducing a configurable switch.

  • Introduces a global flag to toggle wrapping of docs routes
  • Implements conditional prefixing of the OpenAPI docs path in the API initialization
Comments suppressed due to low confidence (1)

api.go:26

  • [nitpick] Consider renaming DoWrapDocsRouteWithPrefix to a more concise name (e.g., WrapDocsWithPrefix) to improve clarity and consistency.
var DoWrapDocsRouteWithPrefix = true

Copy link

codecov bot commented Mar 29, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.10%. Comparing base (4977a7a) to head (a9e8fc3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
api.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          23       23           
  Lines        5296     5297    +1     
=======================================
+ Hits         4931     4932    +1     
  Misses        313      313           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teplinsky-maxim
Copy link
Author

@danielgtaylor, hello Daniel! Please, let me know your thoughts on this MR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant