Skip to content

fix various header issue(NFC) #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Jan 14, 2025

jsoncons_ext/csv/csv_encoder.hpp:202:22: error: use of undeclared identifier
      'csv_errc'; did you mean 'conv_errc'?
  202 |                 ec = csv_errc::source_error;
      |                      ^~~~~~~~
      |                      conv_errc
external/jsoncons+/include/jsoncons_ext/ubjson/ubjson_parser.hpp:512:39: error: 'is_base10' is not a member of 'jsoncons::detail'
--
  | 512 \|                 if (jsoncons::detail::is_base10(text_buffer_.data(),text_buffer_.length()))
  | \|                                       ^~~~~~~~~
external/jsoncons~/include/jsoncons/utility/heap_string.hpp: In member function 'const char_type* jsoncons::utility::heap_string<CharT, Extra, Allocator>::c_str() const':
--
  | external/jsoncons~/include/jsoncons/utility/heap_string.hpp:73:49: error: 'extension_traits' has not been declared
  | 73 \|         const char_type* c_str() const { return extension_traits::to_plain_pointer(p_); }
  | \|                                                 ^~~~~~~~~~~~~~~~
  | external/jsoncons~/include/jsoncons/utility/heap_string.hpp: In member function 'const char_type* jsoncons::utility::heap_string<CharT, Extra, Allocator>::data() const':
  | external/jsoncons~/include/jsoncons/utility/heap_string.hpp:74:48: error: 'extension_traits' has not been declared
  | 74 \|         const char_type* data() const { return extension_traits::to_plain_pointer(p_); }
  | \|                                                ^~~~~~~~~~~~~~~~
  | external/jsoncons~/include/jsoncons/utility/heap_string.hpp: In static member function 'static jsoncons::utility::heap_string_factory<CharT, Extra, Allocator>::pointer jsoncons::utility::heap_string_factory<CharT, Extra, Allocator>::create(const char_type*, std::size_t, Extra, const Allocator&)':
  | external/jsoncons~/include/jsoncons/utility/heap_string.hpp:148:21: error: 'extension_traits' has not been declared
  | 148 \|                 q = extension_traits::to_plain_pointer(ptr);
  | \|                     ^~~~~~~~~~~~~~~~
  | external/jsoncons~/include/jsoncons/utility/heap_string.hpp:160:21: error: 'extension_traits' has not been declared
  | 160 \|                 q = extension_traits::to_plain_pointer(ptr);

Closes #578.

@c8ef
Copy link
Contributor Author

c8ef commented Jan 14, 2025

After this patch, I use the following command to make sure each header is self-contained:

fd | xargs clang++ -I.

@danielaparker
Copy link
Owner

Thanks!

@danielaparker danielaparker merged commit 551f344 into danielaparker:master Jan 16, 2025
52 checks passed
@c8ef c8ef deleted the hdr branch January 16, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure headers are self-contained
2 participants