feat(hashtag-column): allow multiple hashtags #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandolguevara
force-pushed
the
feat/multiple-hashtag
branch
2 times, most recently
from
5aff568 to
04ce72c
Compare
|
we can accept this for now but I was hoping we could have an actual ui for this |
|
This is not really enough. we need to build on this and represent the TimelineKind as Vec<String> for hashtag instead of just String, otherwise it will not be serialized properly, unless we want to have this hacky representation that we always have to parse everywhere... which I'm not sure I'm happy about |
fernandolguevara
force-pushed
the
feat/multiple-hashtag
branch
3 times, most recently
from
76cb305 to
7d2b149
Compare
|
@jb55 can you review this PR again, please? |
fernandolguevara
force-pushed
the
feat/multiple-hashtag
branch
from
7d2b149 to
c2d1cc6
Compare
fernandolguevara
force-pushed
the
feat/multiple-hashtag
branch
from
c2d1cc6 to
7c968d6
Compare
jb55
requested changes
Jun 2, 2025
fernandolguevara
force-pushed
the
feat/multiple-hashtag
branch
2 times, most recently
from
1b14ace to
e73f946
Compare
fernandolguevara
force-pushed
the
feat/multiple-hashtag
branch
from
e73f946 to
3b7f67a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.