Upgraded Field Hub dependencies, especially Phoenix Live View to Version 1.0 #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This state is still incomplete when it comes to the UI part of the application. Tests for the API (i.e. the synchronisation) already pass.
Gettext was never used to translate the interface and got removed as a dependency in b70ee96.
Also removed ` "run --eval FieldHub.CLI.setup() --no-start"` because the setup will be triggered on start anyway, so there is no reason to do it in the setup stage.
The UI now works except the issue evaluation...
- `FieldHubWeb.ChannelCase` is used for tests only. - `FieldHubWeb.Gettext` is currently not really used. - `FieldHubWeb.Layouts` does not contain any actual code at the moment. - `FieldHubWeb.CoreComponents` were automatically generated and only a very small part is used.
After removing the step in 1cd14c9 github actions seem to fail?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also reworked the landing/overview page and the login UI to also be LiveViews, instead of having a partially REST and partially LiveView implemented UI.