feat: cores iap #4449
Open
feat: cores iap #4449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
sshanzel
reviewed
May 6, 2025
sshanzel
reviewed
May 6, 2025
Comment on lines
+46
to
+47
| if (isIOSNative()) { | ||
| return iOSSupportsCoresPurchase(); |
There was a problem hiding this comment.
This means we are not going to allow purchases through web with apple (in-app browser to be specific). Although it is more of an edge case. Should we maybe not check anymore since we will support both Paddle and iap with iPhone products?
There was a problem hiding this comment.
I am fine with both, probably just to check with product.
There was a problem hiding this comment.
Cool. I'll send a message. Just to be sure we won't get into any legal trouble.
sshanzel
reviewed
May 6, 2025
sshanzel
reviewed
May 6, 2025
sshanzel
reviewed
May 6, 2025
capJavert
requested review from
rebelchris,
omBratteng,
ilasw,
sshanzel,
nensidosari and
AmarTrebinjac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://cores-iap.preview.app.daily.dev