Fix launch server breaking when no proxy option is passed. #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When launching Camoufox server without a proxy, the following error occurs:
Error launching server: proxy: expected object, got null
Root Cause
The
launch_options()
function always includes"proxy": proxy
in the returned dictionary, even whenproxy=None
. When serialized to JSON andpassed to Playwright's
launchServer()
, this becomes"proxy": null
, which Playwright rejects.Solution
Only include the proxy key in the returned options when
proxy
is not None. This matches Playwright's expectation that the proxy parametershould either be a valid object or completely absent.
Changes
launch_options()
to conditionally include proxy