fix: Return None for screen size if headless #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datawookie
changed the title
|
Also fixed my issue, wasn't working at all before. Please merge this |
sackmotion
pushed a commit
to sackmotion/camoufox
that referenced
this pull request
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for the work on Camoufox. Many things that were literally impossible previously are now possible thanks to Camoufox.
One issue that I have been hitting my head against is launching Camoufox headless on an EC2 instance. This issue has previously been raised elsewhere:
The second link proposes a simple solution, which I have tested and found to fix the issue.
This MR applies the proposed change to the
get_screen_cons()function.Best regards, Andrew.