-
Notifications
You must be signed in to change notification settings - Fork 59
MVP ETL Module #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MVP ETL Module #90
Conversation
Deploy preview for dagster-university ready! ✅ Preview Built with commit 6d1b59d. |
if: github.event.pull_request.draft == false | ||
uses: ./.github/workflows/template-quality-check.yml | ||
with: | ||
working_directory: ./dagster_university/dagster_and_etl | ||
# TODO: Disable integration tests from GHA | ||
# postgres image has no windows/amd64 | ||
windows_pytest_cmd: uv run pytest dagster_and_etl/completed -v -m "not integration" |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 10 hours ago
To fix the issue, we will add a permissions
block at the root level of the workflow. Since this workflow appears to perform quality checks and does not seem to require write access, we will set the permissions to contents: read
. This ensures that the GITHUB_TOKEN
has only the minimal permissions necessary for the workflow to execute.
-
Copy modified lines R3-R5
@@ -2,2 +2,5 @@ | ||
|
||
permissions: | ||
contents: read | ||
|
||
on: |
Outline of code for ETL course MVP
Lesson 3 - Importing static files
Lesson 4 - Importing data from APIs
Lesson 5 - Importing static files/APIs with embedded ETL (dlt)
Lesson 6 - Importing CDC (Sling)
Lesson 7 - Components