Skip to content

attempt to dgify #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

attempt to dgify #9

wants to merge 2 commits into from

Conversation

PedramNavid
Copy link
Collaborator

No description provided.

@PedramNavid PedramNavid requested a review from Copilot April 21, 2025 05:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to integrate dg configuration into the project and update resource and asset definitions to support the new dg-based workflow.

  • Add new dg configuration in pyproject.toml.
  • Update relative paths and dbt CLI options in the resource definitions.
  • Consolidate definitions with a new definitions.py and remove the legacy init.py.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Added dg configuration and project settings.
opensource_mds/defs/resources.py Updated dbt resource path and CLI flags.
opensource_mds/defs/constants.py Added constants for new data URLs and file paths.
opensource_mds/defs/assets.py Reformatted multi-line SQL commands and updated imports.
opensource_mds/definitions.py Introduced a merged definitions approach using dg.Definitions.merge.
opensource_mds/constants.py Removed legacy constant definitions.
opensource_mds/init.py Removed; switching to explicit definitions via definitions.py.
Comments suppressed due to low confidence (2)

opensource_mds/init.py:1

  • The complete removal of init.py can affect package initialization and module discovery if other parts of the codebase depend on it. Ensure that this removal is intentional and that alternative mechanisms are in place for package initialization.
<deleted file>

opensource_mds/defs/resources.py:37

  • The change in the relative path for project_dir may cause incorrect resolution of the dbt_project directory if the project's structure hasn’t been adjusted accordingly. Please verify that the new path correctly reflects your intended project hierarchy.
    project_dir=file_relative_path(__file__, "../../dbt_project")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant