Add FreshnessStateChange event type
#29568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuthebananu
changed the title
FreshnessStateChange event
This stack of pull requests is managed by Graphite. Learn more about stacking. |
anuthebananu
changed the title
FreshnessStateChange eventFreshnessStateChange event type
anuthebananu
force-pushed
the
anurag/freshness-na-state
branch
from
8922245 to
d14e093
Compare
anuthebananu
force-pushed
the
anurag/new-freshness-state-change-event
branch
from
b7ee9ef to
9b7f8b0
Compare
anuthebananu
force-pushed
the
anurag/new-freshness-state-change-event
branch
from
9b7f8b0 to
3e7009f
Compare
anuthebananu
force-pushed
the
anurag/freshness-na-state
branch
from
d14e093 to
113cfad
Compare
anuthebananu
force-pushed
the
anurag/new-freshness-state-change-event
branch
from
3e7009f to
35264ea
Compare
anuthebananu
changed the base branch from
anurag/freshness-na-state
to
graphite-base/29568
anuthebananu
force-pushed
the
graphite-base/29568
branch
from
113cfad to
cea3b6e
Compare
anuthebananu
force-pushed
the
anurag/new-freshness-state-change-event
branch
from
35264ea to
33fca9f
Compare
anuthebananu
changed the base branch from
graphite-base/29568
to
anurag/freshness-na-state
anuthebananu
commented
May 2, 2025
anuthebananu
force-pushed
the
anurag/new-freshness-state-change-event
branch
from
33fca9f to
a014e75
Compare
anuthebananu
force-pushed
the
anurag/freshness-na-state
branch
from
cea3b6e to
ba968df
Compare
jamiedemaria
previously requested changes
May 2, 2025
There was a problem hiding this comment.
chatted about this offline - let's make a private method for reporting runless asset events that accepts the freshness class (the public method can just call the private one and have more restrictive allowed parameter types). other than that this looks good to me!
anuthebananu
force-pushed
the
anurag/new-freshness-state-change-event
branch
from
f8bea01 to
e1b5e6f
Compare
|
few errant test failures in the last build, nothing related to this PR: https://buildkite.com/dagster/dagster-dagster/builds/121553 |
jamiedemaria
approved these changes
May 5, 2025
anuthebananu
force-pushed
the
anurag/new-freshness-state-change-event
branch
2 times, most recently
from
5df7d45 to
88ecb5e
Compare
anuthebananu
force-pushed
the
anurag/freshness-na-state
branch
from
ba968df to
507b7ba
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit dd19365. |
Merge activity
|
anuthebananu
changed the base branch from
anurag/freshness-na-state
to
graphite-base/29568
anuthebananu
force-pushed
the
anurag/new-freshness-state-change-event
branch
from
b51a161 to
dd19365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adds a new event type -
FreshnessStateChange. This event will be emitted when the freshness state of an asset changes.Also adds a new
_report_runless_asset_eventmethod onDagsterInstance. The new method will allow cloud code to emit the newFreshnessStateChangeevent without polluting the publicreport_runless_asset_eventmethod.How I Tested These Changes
tests in internal < PR link coming soon >
Changelog