Call fs.promises.mkdtemp on the correct path to prevent making a temp dir in $HOME #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
approved these changes
Apr 7, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a custom Dafny installation, this extension copies it to a temp directory. However, the
mkdtempcall has a typo where it usesvscode-dafny-dlls-'instead ofpath.join(os.tmpdir(), 'vscode-dafny-dlls-'), which causes the temp directory to appear in VSCode's cwd (in my case $HOME). This PR fixes that.https://nodejs.org/api/fs.html#fspromisesmkdtempprefix-options also has an example of how to correctly use
mkdtemp.