Fix issue #21 "When page is scrolled to the bottom, scroll-to does no… #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t work" Here: #21 This issue occurs whenever the container or window is already scrolled to the bottom and the easing method causes less than 1px of scrolling for the first scroll animation update. My fix works by requiring at least 1px of scrolling per animation update. This causes the stopAnimation check to always pass instead of prematurely failing on the first scroll animation update.
|
I can confirm that this fix works as intended. |
|
Is this merged into the main branch? |
|
@d-oliveros @jodoherty is this project dead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed here: #21
This issue occurs whenever the container or window is already scrolled
to the bottom and the easing method causes less than 1px of scrolling
for the first scroll animation update.
My fix works by requiring at least 1px of scrolling per animation
update. This causes the stopAnimation check to always pass instead of
prematurely failing on the first scroll animation update.