Skip to content

Explicitly reset Autobrightnesss class after every autobrightness call #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

Explicitly reset Autobrightnesss class after every autobrightness call #632

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fe4a98
Explicitly reset Autobrightnesss class after every autobrightness call
i-jey Jul 3, 2025
a7ab791
add logging statement
i-jey Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ulc_mm_package/utilities/zstack_utility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,18 +519,22 @@ def set_brightness(autobrightness: Autobrightness) -> None:
If the target brightness is not achieved, it will show a message box and return.
"""
status_label.config(text="Adjusting LED brightness...")
logger.info("Adjusting LED brightness...")
root.update()

brightness_achieved = False
while not brightness_achieved:
img, _ = next(camera.yieldImages())
try:
brightness_achieved = autobrightness.runAutobrightness(img)
autobrightness.reset()
except BrightnessTargetNotAchieved:
logger.info("Brightness target not achieved but usable. Proceeding...")
break
autobrightness.reset()
return
except BrightnessCriticallyLow:
logger.info("Brightness critically low. Continuing anyway...")
autobrightness.reset()
return

def start_sweep(n_steps: int = 20, imgs_per_step: int = 2):
Expand Down