Skip to content

v0.5.3 #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 123 commits into from
Dec 23, 2024
Merged

v0.5.3 #581

merged 123 commits into from
Dec 23, 2024

Conversation

i-jey
Copy link
Collaborator

@i-jey i-jey commented Dec 23, 2024 •
edited
Loading

Features

  • Coarse focus utility
  • Pressure limiting for flow control
  • Add CLI convenience calls (remo-run, remo-fix-focus, remo-pneumatic-calibration, remo-dev)
  • QR code option for message boxes
  • Explicit hardware loading dialog
  • Use gauge pressure instead of absolute pressure during pressure check
  • Pass/fail status at end of run with parasitemia visualization

Bugfixes/Improvements

  • Fix parasitemia plot not showing up sometimes
  • Check for cells on both sweep up and sweep down in cell finding
  • Minor phrasing changes
  • Fix unresponsive form for tab button/text boxes
  • Display final frame counter in GUI

Admin

  • Update README.md

mwlkhoo and others added 30 commits October 15, 2024 11:11
@mwlkhoo
Update error titles for consistency
d67e3a9
@mwlkhoo
Only ever use ambient pressure
4c80f70
@mwlkhoo
bump up MIN_PRESSURE_DIFF to 400 hPa
50ef6a7
@i-jey
Check for cells on both the sweep up and sweep down
f6b6aac
@i-jey
use older version of fmt
d5e1d7d
@mwlkhoo
Add qr code handling and appropriate message to each error
f48f3bf
@mwlkhoo
Add qr code images
f474b6a
@i-jey
add the else case for when cell finder is triggered in the midst of a…
4853e1a 
… run, i.e when the lid is opened
@i-jey
sweep in the else case on the way down
33a7c7a
@i-jey
Merge pull request #561 from czbiohub-sf/bidirectional_cell_finder_sweep
9d041b1 
Check for cells on both the sweep up and sweep down
@mwlkhoo
Autoformat
adec2c8
@mwlkhoo
Change condensor -> focal range
81defdf
@mwlkhoo
Merge pull request #563 from czbiohub-sf/fix-focus-msg
ded8dfd 
Change condensor -> focal range
@mwlkhoo
Change pause and error msg
51aea0f
@mwlkhoo
Merge pull request #564 from czbiohub-sf/fix-popup-msgs
a67073e 
Change pause and error msg
@mwlkhoo
Add intermittent dialog for hardware loading and remove freeze/unfreeze
788aaa3
@mwlkhoo
Remove unnecessary import
fc2caeb
@mwlkhoo
onscope fixes: no button in hardware loading and no tab ordering
0e70f6d
@mwlkhoo
Add please wait...
71e655a
@mwlkhoo
Use show instead of exec for no button option
d6bc2b1
@paul-lebel
Fix missing quote marks
2d573e0
@mwlkhoo
Add back missing commas
3a56605
@mwlkhoo
Merge branch 'exception-handling' of github.com:czbiohub-sf/ulc-malar…
93206b1 
…ia-scope into exception-handling
@mwlkhoo
Merge pull request #565 from czbiohub-sf/hardware-loading
69b2106 
Add intermittent dialog for hardware loading and remove freeze/unfreeze
@mwlkhoo
Merge develop in
a0ab465
@paul-lebel
Fix typo
82aeecc
@mwlkhoo
Merge branch 'exception-handling' of github.com:czbiohub-sf/ulc-malar…
182aafa 
…ia-scope into exception-handling
@mwlkhoo
Clean up scopeop imports
8e57cef
@mwlkhoo
Autoformat
d827c21
@paul-lebel
Add missing arg
bd9e3e8
NicholasBratvold and others added 28 commits December 19, 2024 16:23
@NicholasBratvold
formatting
d777694
@NicholasBratvold
formatting
43e33c7
@NicholasBratvold
small fix
d3cdb16
@NicholasBratvold
throw proper errors
d853956
@NicholasBratvold
adjusted acceptable focus limits
5f370aa
@NicholasBratvold
formatting
f712e1e
@NicholasBratvold
Merge pull request #571 from czbiohub-sf/coarse_focus_adjustment_utility
b6c934d 
Crude coarse focus adjustment utility
@i-jey
Add entry points for CLI
78b3980
@i-jey
use main() convention
d1f3215
@i-jey
Use a robust path reference to the file config
6b5eb48
@NicholasBratvold
Merge pull request #577 from czbiohub-sf/cli_entrypoints
f9778cb 
Add entry points for CLI
@i-jey
Merge branch 'develop' into pressure-flowrate-limit
843415b
@i-jey
sign flip on pressure check
f02c064
@i-jey
Pull pressure until we reached the max allowable, then wait for cells…
4d4c4ac 
…, then scan motor
@i-jey
Merge branch 'develop' into pressure-flowrate-limit
78338f3
Don't remove image until post-display to user
26b9193
@paul-lebel
Fixes on scope
38bb4fd
@mwlkhoo
Autoformat
c4c6b6b
@mwlkhoo
Merge pull request #579 from czbiohub-sf/fix-black
b5964dd 
Autoformat
@i-jey
Merge branch 'develop' into pressure-flowrate-limit
c8e6038
@mwlkhoo
One more update
88a0291
@mwlkhoo
autoformat
32dd9f0
@mwlkhoo
Merge pull request #580 from czbiohub-sf/fix-final-frame
d6cb6a7 
One more update
@i-jey
merge branch 'develop' into pressure-flowrate-limit
e44708d
@i-jey
Add logging statements for gauge pressure
39e22e8
@i-jey
make explicit ambient absolute pressure in logging statement
c99ac84
@i-jey
truncate fast flow float in logging statement
4048646
@mwlkhoo
Merge pull request #572 from czbiohub-sf/pressure-flowrate-limit
b0fdb0a 
Pressure flowrate limit
mwlkhoo
mwlkhoo approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@mwlkhoo mwlkhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mwlkhoo mwlkhoo merged commit b815a7a into master Dec 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwlkhoo mwlkhoo mwlkhoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@i-jey @mwlkhoo @paul-lebel @NicholasBratvold