Improved backup SSD folder finding #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k the first one which is valid. This is an update over the original method which simply picked the first folder in /media/pi if the expected SamsungSSD folder was not found.
mwlkhoo
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the scope shuts down expectedly, rarely it will produce a 'ghost'
SamsungSSDfolder under/media/pi. The current way of picking the SSD folder blindly uses/media/pi/SamsungSSDif it exists, and then immediately errors out since the ghost folder has no storage.This improvement checks that
/media/pi/SamsungSSDexists and has sufficient storage. If not, it loops through all the other folders in/media/pi/and tries to find one with sufficient storage. In the error case above where the ghost folder is made, the actual SSD shows up asSamsungSSD1.