Skip to content

Refactored Server.tsx #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactored Server.tsx #36

wants to merge 2 commits into from

Conversation

gamcoh
Copy link
Contributor

@gamcoh gamcoh commented May 8, 2020 •
edited
Loading

Used for of instead of forEach for performance.
Updated Server.tsx to a class.

@gamcoh gamcoh changed the title Refactored Server.tsx, used instead of for performance, transformed… Refactored Server.tsx May 8, 2020
@cyrildiagne
Copy link
Owner

Thanks! May I ask why refactor as class? Not sure it's needed here.

@gamcoh
Copy link
Contributor Author

gamcoh commented May 8, 2020

Well, it's not needed but it is way more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gamcoh @cyrildiagne