Skip to content

chore: use browser tools to install chrome for testing #31868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ chrome-beta-version: &chrome-beta-version "138.0.7204.15"
firefox-stable-version: &firefox-stable-version "137.0"

orbs:
browser-tools: circleci/browser-tools@2.1.0
browser-tools: circleci/browser-tools@2.1.1

defaults: &defaults
parallelism: 1
Expand Down Expand Up @@ -578,11 +578,6 @@ commands:
description: whether or not to install google chrome for testing
type: boolean
default: false
google-chrome-for-testing-channel:
description: Google Chrome for Testing channel to install
type: string
# can be stable, beta, dev, or canary
default: stable
google-chrome-for-testing-version:
description: Google Chrome for Testing version to install
type: string
Expand Down Expand Up @@ -635,13 +630,13 @@ commands:
equal: [ true, << parameters.install-chrome-for-testing >> ]
steps:
- run:
name: Install Chrome for Testing and link it to google-chrome
name: Install unzip
command: |
INSTALL_OUTPUT=$(npx @puppeteer/browsers install chrome@<<parameters.google-chrome-version>> --path /tmp/chrome-for-testing)
DOWNLOAD_DIR=$(echo "$INSTALL_OUTPUT" | grep -o '\/.*\/chrome-linux64')
mv $DOWNLOAD_DIR /opt/chrome-for-testing
ln -fs /opt/chrome-for-testing/chrome /usr/local/bin/chrome
rm -rf /tmp/chrome-for-testing
apt-get update && apt-get install -y unzip
- browser-tools/install_chrome_for_testing:
version: << parameters.google-chrome-for-testing-version >>
install_chromedriver: false

# This code builds better-sqlite3 on Debian 10 (Buster). This is necessary because Debian 10 has the oldest glibc version (2.28) that we support.
#
# Since this is running Docker remote (because the job running the command may not be using an executor with the appropriate glibc version), we need to
Expand Down
Loading