chore: configurable force deferred in snapshot doctor #31865
+775
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacieprins
commented
Jun 11, 2025
| @@ -34,6 +34,7 @@ export async function insertValueInJSString (fileContents: string, obj: Record<s | |||
| && nodePath.node.callee.type === 'Identifier') { | |||
| const functionName = nodePath.node.callee.name | |||
|
|
|||
| // @ts-expect-error - ast is the wrong type | |||
There was a problem hiding this comment.
This is one of those random ts errors that occasionally crop up up that prevents build, even if the file isn't changed.
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/configurable-force-deferred
|
| Run status |
|
| Run duration | 27m 24s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
11
|
Pending
|
1097
|
Skipped
|
3
|
Passing
|
26497
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.27%
|
|
|---|---|
|
Untested elements
|
186
|
|
Tested elements
|
158
|
Accessibility
92.89%
|
|
|---|---|
|
Failed rules
|
3 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
671
|
Tests for review
cypress/e2e/angular.cy.ts • 2 failed tests • webpack-dev-server
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ... > stops waiting when an xhr request is canceled |
| |||||||||||||||||||
| Test | Artifacts | |||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| src/cy/commands/files > #readFile > retries to read when ENOENT |
| |||||||||||||
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Screenshots
|
|
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| cy.origin - cookie login > Max-Age > past max-age -> not logged in |
Test Replay
|
|
The first 5 flaky specs are shown, see all 10 specs in Cypress Cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When upgrading to Electron 35/36, issues were encountered with how v8's mksnapshot serializes certain regular expression objects. To build snapshots when upgrading electron, we need to be able to force certain modules to be fully deferred, not just rewritten.
Because of how sinon mocks dependencies, and the esm dependencies in v8-snapshot, vitest is introduced for unit tests.
This is a WIP/Draft.
[ ] Ensure this approach is sound
[ ] Updated CI to run this vitest suite
[ ] Look at the "multiple projects" warning that the vitest vscode extension is popping up, now that we have multiple packages in the monorepo using vitest
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?