feat: rework window bound commands to use automation clients #31862
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| # Bump this version to force CI to re-create the cache from scratch. | ||
|
|
||
| 6-9-2025 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,12 +23,15 @@ describe('src/cy/commands/location', () => { | |
| cy.url().should('match', /baz/).and('eq', 'http://localhost:3500/foo/bar/baz.html') | ||
| }) | ||
|
|
||
| it('propagates thrown errors from CDP', (done) => { | ||
| cy.on('fail', (err) => { | ||
|
There was a problem hiding this comment. this might be better off in a vite test, but most of these tests are really functioning as some type of integration test 🤷🏻 |
||
| expect(err.message).to.include('CDP was unable to find the AUT iframe') | ||
| done() | ||
| }) | ||
|
|
||
| cy.stub(Cypress, 'automation').withArgs('get:aut:url').rejects(new Error('CDP was unable to find the AUT iframe')) | ||
|
|
||
| cy.url() | ||
| }) | ||
|
|
||
| // https://github.com/cypress-io/cypress/issues/17399 | ||
|
|
@@ -380,7 +383,16 @@ describe('src/cy/commands/location', () => { | |
| context('#location', () => { | ||
| it('returns the location object', () => { | ||
| cy.location().then((loc) => { | ||
| expect(loc).to.have.property('hash') | ||
| expect(loc).to.have.property('host') | ||
| expect(loc).to.have.property('hostname') | ||
| expect(loc).to.have.property('href') | ||
| expect(loc).to.have.property('origin') | ||
| expect(loc).to.have.property('pathname') | ||
| expect(loc).to.have.property('port') | ||
| expect(loc).to.have.property('protocol') | ||
| expect(loc).to.have.property('search') | ||
| expect(loc).to.have.property('searchParams') | ||
|
There was a problem hiding this comment. Is this breaking the properties returned? Notice there's no test to toString: https://docs.cypress.io/api/commands/location#When-not-given-a-key-argument There was a problem hiding this comment. I need to add the There was a problem hiding this comment. @jennifer-shehane I am going to remove the |
||
| }) | ||
| }) | ||
|
|
||
|
|
@@ -402,15 +414,13 @@ describe('src/cy/commands/location', () => { | |
|
|
||
| // https://github.com/cypress-io/cypress/issues/16463 | ||
| it('eventually returns a given key', function () { | ||
| cy.stub(Cypress, 'automation').withArgs('get:aut:url') | ||
| .onFirstCall().resolves('http://localhost:3500') | ||
| .onSecondCall().resolves('http://localhost:3500/my/path') | ||
|
|
||
| cy.location('pathname').should('equal', '/my/path') | ||
| .then(() => { | ||
| expect(Cypress.automation).to.have.been.calledTwice | ||
| }) | ||
| }) | ||
|
|
||
|
|
@@ -614,7 +624,8 @@ describe('src/cy/commands/location', () => { | |
| expect(_.keys(consoleProps)).to.deep.eq(['name', 'type', 'props']) | ||
| expect(consoleProps.name).to.eq('location') | ||
| expect(consoleProps.type).to.eq('command') | ||
|
|
||
| expect(_.keys(consoleProps.props.Yielded)).to.deep.eq(['hash', 'host', 'hostname', 'href', 'origin', 'pathname', 'port', 'protocol', 'search', 'searchParams']) | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,19 +62,16 @@ context('cy.origin location', { browser: '!webkit' }, () => { | |
| expect(consoleProps.name).to.equal('location') | ||
| expect(consoleProps.type).to.equal('command') | ||
|
|
||
|
There was a problem hiding this comment. the signature has slightly changed on the location object, but still matches the docs in https://docs.cypress.io/api/commands/location. The legacy signature (that isn't public) will still be used by Webkit as it is using the window location API |
||
| expect(consoleProps.props.Yielded).to.have.property('hash').that.is.a('string') | ||
| expect(consoleProps.props.Yielded).to.have.property('host').that.is.a('string') | ||
| expect(consoleProps.props.Yielded).to.have.property('hostname').that.is.a('string') | ||
| expect(consoleProps.props.Yielded).to.have.property('href').that.is.a('string') | ||
| expect(consoleProps.props.Yielded).to.have.property('origin').that.is.a('string') | ||
| expect(consoleProps.props.Yielded).to.have.property('pathname').that.is.a('string') | ||
| expect(consoleProps.props.Yielded).to.have.property('port').that.is.a('string') | ||
| expect(consoleProps.props.Yielded).to.have.property('protocol').that.is.a('string') | ||
| expect(consoleProps.props.Yielded).to.have.property('search').that.is.a('string') | ||
| expect(consoleProps.props.Yielded).to.have.property('searchParams').that.is.an('object') | ||
| }) | ||
| }) | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to indicate why this would be breaking at all? It's hard to understand what situation would break here and what action I would need to take as a user reading this (or maybe this would be good for the migration guide?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a breaking change but I marked it as a feature. It's more of an improvement if anything I would think