-
Notifications
You must be signed in to change notification settings - Fork 3.3k
chore: update app to cypress-example-kitchensink v5.0.0 #31825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update app to cypress-example-kitchensink v5.0.0 #31825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeMcC399 For this update - we have scripts that we run on release that will update the gh-pages branch - so this doesn't need to be done directly.
cypress/guides/release-process.md
Line 164 in a0a4eb1
16. If needed, deploy the updated [`cypress-example-kitchensink`][cypress-example-kitchensink] to `example.cypress.io` by following [these instructions under "Deployment"](../packages/example/README.md). |
You should just need to bump our dependency of the cypress-example-kitchensink dep and we will handle the build/deploy.
I ran the script yarn workspace @packages/example deploy to update the gh-pages locally through a PR. This is a bit safer than doing it directly, as otherwise you push directly to the website without seeing what you're doing. Also the Circleci script was accidently deleted by @AtofStryker so it needs to be put back again. It's up to you if you want to process this PR, which should produce correct results, or if you want to handle it manually on your side. Your decision. |
This comment was marked as outdated.
This comment was marked as outdated.
384a40f
to
afa5ca8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
afa5ca8
to
37e36fd
Compare
|
@MikeMcC399 I of course forgot this. |
Additional details
Updates https://github.com/cypress-io/cypress/tree/gh-pages for publication to https://example.cypress.io
Sourced from cypress-example-kitchensink@5.0.0
Steps to test
After merge:
type()
section there should be a space after each//
cy.exec()
sectionelse {
should be on a separate linecy.getAllLocalStorage()
the propertiesprop1
-prop3
should not be quoted. Same forcy.getAllSessionStorage()
withprop4
-prop6
How has the user experience changed?
Minor visible changes on https://example.cypress.io
PR Tasks
cypress-documentation
?type definitions
?