Skip to content

chore: update app to cypress-example-kitchensink v5.0.0 #31825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Jun 4, 2025

Additional details

Updates https://github.com/cypress-io/cypress/tree/gh-pages for publication to https://example.cypress.io

Sourced from cypress-example-kitchensink@5.0.0

Steps to test

After merge:

URL Expect
https://example.cypress.io/commands/actions In the type() section there should be a space after each //
https://example.cypress.io/commands/misc In the cy.exec() section else { should be on a separate line
https://example.cypress.io/commands/storage In cy.getAllLocalStorage() the properties prop1 - prop3 should not be quoted. Same for cy.getAllSessionStorage() with prop4 - prop6
https://example.cypress.io/commands/waiting Check that the paragraph "More information:" is displayed correctly
https://example.cypress.io/commands/window Check that the page appears correct

How has the user experience changed?

Minor visible changes on https://example.cypress.io

PR Tasks

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcC399 For this update - we have scripts that we run on release that will update the gh-pages branch - so this doesn't need to be done directly.

16. If needed, deploy the updated [`cypress-example-kitchensink`][cypress-example-kitchensink] to `example.cypress.io` by following [these instructions under "Deployment"](../packages/example/README.md).

You should just need to bump our dependency of the cypress-example-kitchensink dep and we will handle the build/deploy.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

I ran the script

yarn workspace @packages/example deploy

to update the gh-pages locally through a PR. This is a bit safer than doing it directly, as otherwise you push directly to the website without seeing what you're doing.

Also the Circleci script was accidently deleted by @AtofStryker so it needs to be put back again.

It's up to you if you want to process this PR, which should produce correct results, or if you want to handle it manually on your side. Your decision.

@MikeMcC399 MikeMcC399 marked this pull request as draft June 4, 2025 16:46
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 changed the title chore: update app to cypress-example-kitchensink v4.1.0 chore: update app to cypress-example-kitchensink v5.0.0 Jun 5, 2025
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review June 18, 2025 06:04
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

For this update - we have scripts that we run on release that will update the gh-pages branch - so this doesn't need to be done directly.

16. If needed, deploy the updated [`cypress-example-kitchensink`][cypress-example-kitchensink] to `example.cypress.io` by following [these instructions under "Deployment"](../packages/example/README.md).

You should just need to bump our dependency of the cypress-example-kitchensink dep and we will handle the build/deploy.

@jennifer-shehane
Copy link
Member

@MikeMcC399 I of course forgot this.

@jennifer-shehane jennifer-shehane merged commit 90858cf into cypress-io:gh-pages Jun 18, 2025
3 checks passed
@MikeMcC399 MikeMcC399 deleted the update/gh-pages branch June 19, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants