chore: add minimal built-ins back in to @cypress/webpack-batteries-included-preprocessor
#31815
+48
−1,893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
feat/add_built_ins_minimal
|
| Run status |
|
| Run duration | 16m 52s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
27
|
Skipped
|
0
|
Passing
|
768
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
62.34%
|
|
|---|---|
|
Untested elements
|
27
|
|
Tested elements
|
48
|
Accessibility
96.16%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
121
|
|
The |
jennifer-shehane
requested changes
Jun 16, 2025
| expect(require('os')).to.be.eql({}) | ||
| expect(require('path')).to.be.eql({}) | ||
| expect(require('os')).to.be.an('object').and.have.property('platform') | ||
| expect(require('path')).to.be.an('object').and.have.property('join') | ||
| expect(require('perf_hooks')).to.eql({}) | ||
| expect(require('punycode')).to.be.eql({}) |
There was a problem hiding this comment.
@AtofStryker No test for process?
There was a problem hiding this comment.
@jennifer-shehane I think it was just missing. added in 70453bd
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
jennifer-shehane
approved these changes
Jun 17, 2025
cypress-app-bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
… to `@cypress/webpack-batteries-included-preprocessor` (#31815)
cypress-app-bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…o `@cypress/webpack-batteries-included-preprocessor` (#31815)
cypress-app-bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
… to `@cypress/webpack-batteries-included-preprocessor` (#31815)
cypress-app-bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…o `@cypress/webpack-batteries-included-preprocessor` (#31815)
cypress-app-bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
… to `@cypress/webpack-batteries-included-preprocessor` (#31815)
cypress-app-bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…o `@cypress/webpack-batteries-included-preprocessor` (#31815)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
After removing all the webpack 4 built-ins from Cypress 15, We realized that some built-ins should likely be shipped with
@cypress/webpack-batteries-included-preprocessorin order to not make the change as disruptive. These built-ins are the commonly used node built-ins from observation and happen to bebuffer,path,process,os, andstreamSteps to test
Should now work where
processandbufferare used.How has the user experience changed?
Should make the change less disruptive if using any of the above built ins. Otherwise, no change is realized to the end user
PR Tasks
cypress-documentation?type definitions?