feat: prompt (WIP - do not merge) #31752
Open
+3,397
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
feat/cy-prompt
|
| Run status |
|
| Run duration | 18m 14s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
2
|
Pending
|
29
|
Skipped
|
0
|
Passing
|
817
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
64.37%
|
|
|---|---|
|
Untested elements
|
29
|
|
Tested elements
|
56
|
Accessibility
96.26%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
145
|
Tests for review
cypress\e2e\studio\studio.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > does not create a new test if the Save test modal is closed |
Test Replay
Screenshots
|
|
cypress\e2e\studio\studio.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > removes the studio url parameters when saving a new test |
Test Replay
Screenshots
|
|
cypress\e2e\choose-a-browser.cy.ts • 1 flaky test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| Choose a browser page > System Browsers Detected > launches when --browser is passed alone through the command line |
Test Replay
Screenshots
|
|
* feat: cy prompt infrastructure * refactor and add tests * refactor * rename experimental config * prompt * fix test * Update cy-prompt-development.md * Update cy-prompt-development.md * PR comments * Update packages/server/lib/cloud/api/cy-prompt/get_cy_prompt_bundle.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * PR comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ryanthemanuel
requested review from
brian-mann and
jennifer-shehane
as code owners
* chore: add cdp connection to cy prompt * minor fix * fix type build * try to fix build * Update packages/server/lib/browsers/browser-cri-client.ts Co-authored-by: Bill Glesias <bglesias@gmail.com> * Update packages/server/lib/browsers/browser-cri-client.ts Co-authored-by: Bill Glesias <bglesias@gmail.com> * do not support prompt in firefox or webkit * rework timing of lifecycle * refactor * fix tests * troubleshooting * troubleshooting * fix tests * additional troubleshooting * additional troubleshooting * additional troubleshooting * attempt to fix build * add back * debugging * debugging * debugging * debugging * clean up * fix unit tests * rework --------- Co-authored-by: Bill Glesias <bglesias@gmail.com>
…#31803) * chore: add promptBackend as an additional Cypress-attached function * Update packages/app/src/runner/event-manager.ts * update types * fix types * fix spacing * refactor * additional refactor * fix type build * fix build * refactor * reword messages * fix * debugging * undo debugging * PR comment * fix tests * fix tests * fix tests * fix test
* chore: add watcher for cy-prompt development * test caching * fix types
…31835) * internal: (cy.prompt) handle errors better in the command definition * internal: (cy.prompt) add timeout and handle loading errors more cleanly * add process environment variable * clean up test * update JSDoc
* chore: handle errors * Fix ts, add test * Fix error title * Fix ts * Fix ts
| @@ -31,6 +31,7 @@ exports['module api and after:run results'] = ` | |||
| "experimentalSourceRewriting": false, | |||
| "experimentalSingleTabRunMode": false, | |||
| "experimentalStudio": false, | |||
| "experimentalPromptCommand": false, | |||
There was a problem hiding this comment.
Was requested review as Code Owner due to the results API change here. This change looks good. 👍🏻
* share error utils with cloud * additional rework * Fix command, add isOpenMode * Add / fix test * fix ts --------- Co-authored-by: Ryan Manuel <ryanm@cypress.io>
…31904) * chore: (cy.prompt) add infrastructure to support a Get Code modal * fix tests * fix code paths * Update eject button styles * handle errors * update types * Update packages/server/lib/socket-base.ts * Fix cy test * update readme --------- Co-authored-by: estrada9166 <estrada9166@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?