misc: Add Cursor IDE to Cypress recognized file editors #31691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
expand-ide-recognition
|
| Run status |
|
| Run duration | 18m 58s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
13
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32159
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.83%
|
|
|---|---|
|
Untested elements
|
190
|
|
Tested elements
|
165
|
Accessibility
92.74%
|
|
|---|---|
|
Failed rules
|
3 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
697
|
| @@ -95,7 +95,7 @@ const icons: Record<string, FunctionalComponent<SVGAttributes, {}>> = { | |||
| const customEditor = { id: 'custom', icon: Terminal, name: 'Custom', binary: 'custom' } | |||
|
|
|||
| const editorOptions = computed(() => { | |||
| const editors = props.gql.localSettings.availableEditors?.map((x) => ({ ...x, icon: icons[x.id] })) || [] | |||
| const editors = props.gql.localSettings.availableEditors?.map((x) => ({ ...x, icon: icons[x.id] ?? icons['custom'] })) || [] | |||
There was a problem hiding this comment.
Is it not possible to utilize a Cursor icon?
There was a problem hiding this comment.
I couldn't find one in the icon library that we're currently using. It just doesn't seem worth the effort to track down and get in. The icons in our vue components are pretty gnarly.
ryanthemanuel
approved these changes
May 13, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
I realized Cypress doesn't look for Cursor IDE when selecting an IDE to open files with - and didn't want to find the Application's install path. So I added Cursor as supported.
I couldn't find a logo for cursor that was within our existing icon dependency, so I just defaulted to a generic icon which I think is better than notthing.
Steps to test
yarn cypress:openwith yourpreferredEditorBinarycleared from your__global__preferences.How has the user experience changed?
Before
After
PR Tasks
cypress-documentation?type definitions?