misc: remove recommendation for record false in error message #31676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
remove-record-false-error
|
| Run status |
|
| Run duration | 11m 36s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
685
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
37.62%
|
|
|---|---|
|
Untested elements
|
131
|
|
Tested elements
|
79
|
Accessibility
92.36%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
1 moderate
1 minor
|
|
Failed elements
|
429
|
AtofStryker
approved these changes
May 13, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR updates the error message when a
projectIdandkeyare present but not--recordto remove the recommendation for passing--record false, which is undocumented.--record falseis not explicitly documented. While we have code that should make this work as intended, I do know there is one bug around this usage and we've asked users to update their code to just remove the--recordflag in that case instead of passing--record false.This was originally surfaced in this discussion.
Steps to test
Run cypress run with projectId and key flags but no record flag
How has the user experience changed?
Shorter error message on this failure
PR Tasks
cypress-documentation?type definitions?