internal: hide selector playground and studio toolbar when studio beta enabled #31666
+271
−242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
studio-beta-hide-playground-studio-toolbar
|
| Run status |
|
| Run duration | 18m 58s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
10
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32159
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.68%
|
|
|---|---|
|
Untested elements
|
190
|
|
Tested elements
|
164
|
Accessibility
92.74%
|
|
|---|---|
|
Failed rules
|
3 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
890
|
mabela416
reviewed
May 8, 2025
| const shouldShowStudioButton = computed(() => { | ||
| return !!props.gql.studio && studioStatus.value === 'ENABLED' && !studioStore.isOpen | ||
| return studioStatus.value === 'ENABLED' && !!props.gql.studio && !studioStore.isOpen |
There was a problem hiding this comment.
just a nit but we could use studioBetaAvailable.value here
There was a problem hiding this comment.
Yah I did do this and then was debugging something and reverted it.
mabela416
approved these changes
May 8, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
Automated:
studio-cloud.cy.tsin app e2e testsSpecRunnerHeaderOpenMode.cy.tsxin app CT testsManually:
yarn cypress:openin the root withoutCYPRESS_ENABLE_CLOUD_STUDIO, ensure selector playground and studio toolbar work normally outside of beta when activating studioyarn cypress:openin the root WITHCYPRESS_ENABLE_CLOUD_STUDIO=true, ensure selector playground and studio toolbar are hidden when activating studioHow has the user experience changed?
Changes are to internal Cypress team only
Before
After
PR Tasks
cypress-documentation?type definitions?