internal: (studio) quality of life improvements for the studio lifecycle #31663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/internal/provide-more-info-on-studio-session-failures
|
| Run status |
|
| Run duration | 19m 25s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
8
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32157
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.24%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
166
|
Accessibility
92.74%
|
|
|---|---|
|
Failed rules
|
3 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
889
|
mschile
reviewed
May 9, 2025
| @@ -47,6 +46,10 @@ const downloadStudioBundleToTempDirectory = async ({ studioUrl, projectId }: Opt | |||
| encrypt: 'signed', | |||
| }) | |||
|
|
|||
| if (!response.ok) { | |||
| throw new Error(`Failed to download studio bundle: ${response.statusText}`) | |||
There was a problem hiding this comment.
What's the user experience with throwing this error?
There was a problem hiding this comment.
We catch it up stream and report it. I'll take a look at @astone123's PR to make sure it plays nicely there, but prior to this change it would actually have failed in a different (more confusing) way.
mschile
approved these changes
May 9, 2025
ryanthemanuel
deleted the
ryanm/internal/provide-more-info-on-studio-session-failures
branch
cypress-app-bot
pushed a commit
that referenced
this pull request
May 11, 2025
…ents for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 11, 2025
…ts for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 11, 2025
…ents for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 11, 2025
…ts for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 11, 2025
…ents for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 11, 2025
…ts for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 12, 2025
…ents for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 12, 2025
…ts for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 12, 2025
…ents for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 12, 2025
…ts for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 12, 2025
…ents for the studio lifecycle (#31663)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 12, 2025
…ts for the studio lifecycle (#31663)
jennifer-shehane
pushed a commit
that referenced
this pull request
May 12, 2025
* chore: updating v8 snapshot cache * index on develop: e3a7994 internal: (studio) quality of life improvements for the studio lifecycle (#31663) * index on develop: e3a7994 internal: (studio) quality of life improvements for the studio lifecycle (#31663) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane
pushed a commit
that referenced
this pull request
May 12, 2025
* chore: updating v8 snapshot cache * index on develop: e3a7994 internal: (studio) quality of life improvements for the studio lifecycle (#31663) * index on develop: e3a7994 internal: (studio) quality of life improvements for the studio lifecycle (#31663) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane
pushed a commit
that referenced
this pull request
May 12, 2025
* chore: updating v8 snapshot cache * index on develop: e3a7994 internal: (studio) quality of life improvements for the studio lifecycle (#31663) * index on develop: e3a7994 internal: (studio) quality of life improvements for the studio lifecycle (#31663) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR adds a few quality of life improvements for the Studio initialization workflow. It provides additional debugging context when things fail.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?