fix: hang when navigating to about:blank #31634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
approved these changes
May 2, 2025
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/about_blank_hang
|
| Run status |
|
| Run duration | 09m 53s |
| Commit |
|
| Committer | Matthew Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
694
|
Skipped
|
0
|
Passing
|
130
|
| View all changes introduced in this branch ↗︎ | |
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We currently set the
iframe.srctoabout:blankprior to registering theloadlistener. Ifabout:blankis loaded before we register the event, the promise will hang.Steps to test
We don't currently have a good way to test this since we don't have unit testing setup for the App. But you can run Cypress and verify
about:blankis still displayed and doesn't hang.How has the user experience changed?
Doesn't have the potential to hang when visiting
about:blank.PR Tasks
cypress-documentation?type definitions?