Skip to content

fix: no longer hang when piping stdout+stderr to a file under certain conditions #31631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025

Conversation

cacieprins
Copy link
Contributor

Additional details

When using @cypress/grep results in running many spec files, piping stdout and stderr to a file can cause Cypress to hang. Downgrading cli-table3 to 0.6.1 resolves the issue.

Steps to test

With https://github.com/eswanny22/cypress-cli-table3-issue, run the test suite with similar args to: npx cypress run --env grepTags=@issue,grepFilterSpecs=true > testResults.log 2>&1. Cypress should not hang before running any tests.

How has the user experience changed?

PR Tasks

@cacieprins cacieprins marked this pull request as ready for review May 2, 2025 19:03
Copy link

cypress bot commented May 5, 2025

cypress    Run #62168

Run Properties:  status check passed Passed #62168  •  git commit 9596120839: Merge branch 'develop' into dep/revert-cli-table3
Project cypress
Branch Review dep/revert-cli-table3
Run status status check passed Passed #62168
Run duration 08m 37s
Commit git commit 9596120839: Merge branch 'develop' into dep/revert-cli-table3
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 19
View all changes introduced in this branch ↗︎
UI Coverage  20%
  Untested elements 4  
  Tested elements 1  
Accessibility  89.8%
  Failed rules  0 critical   2 serious   0 moderate   0 minor
  Failed elements 11  

@cacieprins cacieprins merged commit 1119625 into develop May 6, 2025
91 checks passed
@cacieprins cacieprins deleted the dep/revert-cli-table3 branch May 6, 2025 14:29
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 6, 2025

Released in 14.3.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.3.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli-table3 0.6.5 prevents tests from running when using cypress/grep and piping output to a file
2 participants