chore: (studio) set up infrastructure for cypress in cypress tests for cloud studio #31621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for cloud studio
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/internal/cy-in-cy-cloud-studio
|
| Run status |
|
| Run duration | 12m 10s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
225
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
62.5%
|
|
|---|---|
|
Untested elements
|
31
|
|
Tested elements
|
55
|
Accessibility
96.2%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
197
|
ryanthemanuel
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR sets up the infrastructure to support Cypress in Cypress tests for cloud Studio. Key changes include updating the environment variable logic to prioritize CYPRESS_CONFIG_ENV, adding new Cypress commands and helper functions to simulate studio and cloud interactions, and updating tests and documentation.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/server/lib/project-base.ts | Updated environment variable logic to prioritize CYPRESS_CONFIG_ENV over CYPRESS_INTERNAL_ENV |
| packages/server/lib/cloud/api/studio/get_and_initialize_studio_manager.ts | Updated environment variable logic to prioritize CYPRESS_CONFIG_ENV over CYPRESS_INTERNAL_ENV |
| packages/server/lib/StudioLifecycleManager.ts | Updated environment variable logic to prioritize CYPRESS_CONFIG_ENV over CYPRESS_INTERNAL_ENV |
| packages/frontend-shared/cypress/support/e2e.ts | Added interfaces and Cypress commands for mocking cloud studio requests and full snapshot behavior |
| packages/frontend-shared/cypress/fixtures/dummy-protocol.js | Added a dummy protocol file for inner Cypress tests |
| packages/frontend-shared/cypress/e2e/e2ePluginSetup.ts | Extended task setup to support studio mocks and cleared cloud studio-related env variables and mocks |
| packages/app/cypress/e2e/studio/studio.cy.ts | Added a new e2e test to validate the cloud studio session with AI enabled |
| guides/studio-development.md / guides/README.md | Updated documentation to include studio development and protocol instructions |
Files not reviewed (1)
- packages/frontend-shared/package.json: Language not supported
Comments suppressed due to low confidence (3)
packages/server/lib/project-base.ts:410
- This update prioritizes CYPRESS_CONFIG_ENV over CYPRESS_INTERNAL_ENV for determining the cloud environment. Please ensure that this change is documented in the related configuration guides.
const cloudEnv = (process.env.CYPRESS_CONFIG_ENV || process.env.CYPRESS_INTERNAL_ENV || 'production') as 'development' | 'staging' | 'production'
packages/server/lib/cloud/api/studio/get_and_initialize_studio_manager.ts:128
- The updated environment variable logic here mirrors the change in project-base.ts, ensuring consistent behavior across modules. Verify that any references to the environment configuration in documentation and tests are updated accordingly.
const cloudEnv = (process.env.CYPRESS_CONFIG_ENV || process.env.CYPRESS_INTERNAL_ENV || 'production') as 'development' | 'staging' | 'production'
packages/server/lib/StudioLifecycleManager.ts:55
- The change to use CYPRESS_CONFIG_ENV first in the environment variable check promotes consistency. Ensure that any developer-facing materials reflect this new priority for configuring the cloud environment.
const cloudEnv = (process.env.CYPRESS_CONFIG_ENV || process.env.CYPRESS_INTERNAL_ENV || 'production') as 'development' | 'staging' | 'production'
mabela416
approved these changes
May 2, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR adds infrastructure to support cypress in cypress testing. See the README for specifics.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?