internal: (studio) when errors occur in development, log them and do not throw and do not send to Sentry #31614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… throw and do not send to Sentry
There was a problem hiding this comment.
Pull Request Overview
This PR updates the error handling behavior for studio errors in development by logging errors instead of throwing them or sending them to Sentry.
- Adjusts error handling conditions to log errors when not in production
- Replaces throwing errors with console error logging in development
Comments suppressed due to low confidence (1)
packages/server/lib/cloud/api/studio/report_studio_error.ts:38
- The comment on line 38 is now outdated since the error is logged instead of being thrown in development. Consider updating the comment to accurately describe the new error handling behavior.
// When developing locally, we want to throw the error so we can see it in the console
ryanthemanuel
commented
Apr 30, 2025
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/chore/do-not-throw-on-errors
|
| Run status |
|
| Run duration | 18m 36s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
12
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32150
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
46.87%
|
|
|---|---|
|
Untested elements
|
173
|
|
Tested elements
|
157
|
Accessibility
92.67%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
886
|
… throw and do not send to Sentry
… throw and do not send to Sentry
mschile
approved these changes
Apr 30, 2025
cypress-app-bot
pushed a commit
that referenced
this pull request
May 1, 2025
…elopment, log them and do not throw and do not send to Sentry (#31614)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 1, 2025
…opment, log them and do not throw and do not send to Sentry (#31614)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 1, 2025
…elopment, log them and do not throw and do not send to Sentry (#31614)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 1, 2025
…opment, log them and do not throw and do not send to Sentry (#31614)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 1, 2025
…elopment, log them and do not throw and do not send to Sentry (#31614)
cypress-app-bot
pushed a commit
that referenced
this pull request
May 1, 2025
…opment, log them and do not throw and do not send to Sentry (#31614)
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When studio errors occur in development, log them and do not throw and do not send to Sentry
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?