-
Notifications
You must be signed in to change notification settings - Fork 3.3k
perf: ensure the pausing event listeners are removed #31596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
Project |
cypress
|
Branch Review |
mschile/handle_pausing
|
Run status |
|
Run duration | 19m 06s |
Commit |
|
Committer | Matt Schile |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
9
|
|
1232
|
|
0
|
|
32150
|
View all changes introduced in this branch ↗︎ |
UI Coverage
46.33%
|
|
---|---|
|
185
|
|
164
|
Accessibility
92.7%
|
|
---|---|
|
3 critical
8 serious
2 moderate
2 minor
|
|
887
|
AtofStryker
approved these changes
Apr 28, 2025
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In open mode, when a new spec is run or the existing spec is rerun, we aren't clearing the reporter listeners in
pausing.ts
. UpdatedhandlePausing()
to ensure the previous event listeners are removed before new ones are added.Steps to test
In open mode, rerun a spec more than 10 times and verify the event emitters memory leak message is not received:
How has the user experience changed?
Before (test fails showing we have two listeners attached when there should've only been one):

After (test passes showing the correct amount of listeners attached):

PR Tasks
cypress-documentation
?type definitions
?