misc: update URL bar to not flash white when urlIsLoading #31557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix-url-white-blink
|
| Run status |
|
| Run duration | 19m 12s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
13
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32147
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.2%
|
|
|---|---|
|
Untested elements
|
186
|
|
Tested elements
|
164
|
Accessibility
92.7%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
887
|
mschile
approved these changes
Apr 22, 2025
mabela416
approved these changes
Apr 23, 2025
|
The changelog entry was not removed from the previous version, so it's duplicated at the moment still. |
|
@MikeMcC399 Thanks. Fixing here: #31644 |
3 tasks
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Removed the
bg-gray-50styling that showed up whenautStore.isLoadingUrl.Honestly, I don't see a lot of value in showing the URL as a slightly different color when the url is loading, so I've just removed the conditional logic here - the background will always be dark.
Steps to test
yarn cypress:openand enter experimental studio with the new Studio panel open.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?