Skip to content

fix: add chrome for testing dependencies to example #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Jun 12, 2025

Situation

In the examples/chrome-for-testing > README Google Chrome for Testing is installed using @puppeteer/browsers

The instructions to install system dependencies using the following from the README for @puppeteer/browsers was not used, because it did not work:

npx puppeteer browsers install chrome --install-deps

Although the example runs without checking for all dependencies, there may be some edge cases that need the complete set of dependencies installed.

Change

In examples/chrome-for-testing/Dockerfile use installed contents of /opt/chrome-for-testing/deb.deps to install any missing dependencies.

Verification

Execute the following:

cd examples/chrome-for-testing              # Use a pre-configured simple Cypress E2E project
npm ci                                      # Install all dependencies
docker build --progress plain -t test-chrome-for-testing .   # Build a new image
docker run --rm --entrypoint bash test-chrome-for-testing -c "npx cypress run --browser chrome-for-testing" # Run Cypress test using Chrome for Testing

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 self-assigned this Jun 12, 2025
@MikeMcC399 MikeMcC399 force-pushed the example/cft-deps branch 4 times, most recently from f7ea917 to 1f47d2d Compare June 12, 2025 12:31
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as draft June 12, 2025 12:58
@MikeMcC399 MikeMcC399 marked this pull request as ready for review June 12, 2025 15:04
@AtofStryker AtofStryker merged commit 577ba9e into cypress-io:master Jun 12, 2025
48 checks passed
@MikeMcC399
Copy link
Collaborator Author

@MikeMcC399 MikeMcC399 deleted the example/cft-deps branch June 12, 2025 19:26
@AtofStryker
Copy link
Contributor

@MikeMcC399 once the outage is over Ill re kick off this job

@MikeMcC399
Copy link
Collaborator Author

@AtofStryker

once the outage is over Ill re kick off this job

Thank you very much for your offer! This would make sense, as otherwise the README will continue to show a failed build.

https://status.npmjs.org/incidents/dn5mcp85737y is marked

Resolved
This incident has been resolved.
Posted 17 hours ago. Jun 12, 2025 - 20:58 UTC

@AtofStryker
Copy link
Contributor

@AtofStryker

once the outage is over Ill re kick off this job

Thank you very much for your offer! This would make sense, as otherwise the README will continue to show a failed build.

https://status.npmjs.org/incidents/dn5mcp85737y is marked

Resolved This incident has been resolved. Posted 17 hours ago. Jun 12, 2025 - 20:58 UTC

@MikeMcC399 images should now be published!

@MikeMcC399
Copy link
Collaborator Author

@AtofStryker

images should now be published!

Thanks for following up! In fact there were no images to publish, only examples, and the GitHub Actions job also failed due to the npm HTTP 504 issue, so theoretically, this would also need to be re-run.

However, in the meantime, I realised that I made a mistake in this PR and I forgot to update the Chrome for Testing example README. I guess I was jumping between too many repos and related issues in parallel and I got this wrong.

So, no need to re-run here. I've submitted a new PR #1370 to fix the README, and if that merges correctly, then we'll be fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants