-
Notifications
You must be signed in to change notification settings - Fork 393
fix: add chrome for testing dependencies to example #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
f7ea917
to
1f47d2d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1f47d2d
to
afc6a27
Compare
afc6a27
to
6e3c86e
Compare
6e3c86e
to
1b1598e
Compare
|
@MikeMcC399 once the outage is over Ill re kick off this job |
Thank you very much for your offer! This would make sense, as otherwise the README will continue to show a failed build. https://status.npmjs.org/incidents/dn5mcp85737y is marked Resolved |
@MikeMcC399 images should now be published! |
Thanks for following up! In fact there were no images to publish, only examples, and the GitHub Actions job also failed due to the npm HTTP 504 issue, so theoretically, this would also need to be re-run. However, in the meantime, I realised that I made a mistake in this PR and I forgot to update the Chrome for Testing example README. I guess I was jumping between too many repos and related issues in parallel and I got this wrong. So, no need to re-run here. I've submitted a new PR #1370 to fix the README, and if that merges correctly, then we'll be fine! |
Situation
In the examples/chrome-for-testing > README Google Chrome for Testing is installed using @puppeteer/browsers
The instructions to install system dependencies using the following from the README for @puppeteer/browsers was not used, because it did not work:
Although the example runs without checking for all dependencies, there may be some edge cases that need the complete set of dependencies installed.
Change
In examples/chrome-for-testing/Dockerfile use installed contents of
/opt/chrome-for-testing/deb.deps
to install any missing dependencies.Verification
Execute the following: