docs: update contributing image size section #1080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The CONTRIBUTING > Minimize image sizes document section is outdated concerning Debian base versions.
The default
BASE_IMAGE
is determined by the same named property in the factory/.env file.When
cypress/factory
was introduced through PR #812 in January 2023BASE_IMAGE
was set todebian:bullseye-slim
(Debian 11).Since PR #1057 on May 30, 2024
BASE_IMAGE
is set todebian:12-slim
(codenamebookworm
).The prior PR #597 from March 2022, introduced
bullseye-slim
for Node.js16
and above whilst retainingbuster-slim
for Node.js14
and below.Summary
Node.js
18
is the lowest currently supported version, so all currently supported Cypress Docker images have been generated using adebian:*slim
variant.Descriptions of the process before
cypress/factory
was introduced are no longer relevant for future contributions.Change
The section CONTRIBUTING > Minimize image sizes is reworked to give better advice for changes that contributors may need to make.
Obsolete information regarding image generation prior to the introduction of
cypress/factory
is removed.A snapshot of current sizes is included:
docker images --format "table {{.Repository}} {{.Tag}} {{.Size}}"