Skip to content

fix: remove obsolete environment variable npm_config_unsafe_perm #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: remove obsolete environment variable npm_config_unsafe_perm #1078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion factory/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ FACTORY_DEFAULT_NODE_VERSION='20.13.1'
NODE_VERSION="${FACTORY_DEFAULT_NODE_VERSION}"

# Update this to deploy the docker factory if you make changes to factory.Dockerfile or install scripts
FACTORY_VERSION='4.0.0'
FACTORY_VERSION='4.0.1'

# Chrome versions: https://www.ubuntuupdates.org/package/google_chrome/stable/main/base/google-chrome-stable
CHROME_VERSION='125.0.6422.60-1'
Expand Down
4 changes: 4 additions & 0 deletions factory/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change log

## 4.0.1

* Removed obsolete environment variable `npm_config_unsafe_perm`, not used or needed in npm `v7` and later. Addressed in [#1078](https://github.com/cypress-io/cypress-docker-images/pull/1078)

## 4.0.0

* Updated Debian base image to `debian:12-slim` (codename `bookworm`). Addressed in [#1057](https://github.com/cypress-io/cypress-docker-images/pull/1057)
Expand Down
2 changes: 0 additions & 2 deletions factory/factory.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ ENV DBUS_SESSION_BUS_ADDRESS=/dev/null \
TERM=xterm \
# avoid million NPM install messages
npm_config_loglevel=warn \
# allow installing when the main user is root
npm_config_unsafe_perm=true \
# avoid too many progress messages
# https://github.com/cypress-io/cypress/issues/1243
CI=1 \
Expand Down