Skip to content

chore: fix failing contributing links #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

CONTRIBUTING.md fails markdown-link-check.

  ERROR: 5 dead links found!
  [✖] /factory/README.md → Status: 400
  [✖] /factory/factory.Dockerfile → Status: 400
  [✖] /factory/installScripts/ → Status: 400
  [✖] /factory/CHANGELOG.md → Status: 400
  [✖] /factory/.env → Status: 400

Change

Make failing links relative e.g.

/factory/README.md => ./factory/README.md

Verification

npm ci
npx markdown-link-check CONTRIBUTING.md

@cypress-app-bot
Copy link

@MikeMcC399
Copy link
Collaborator Author

@MikeMcC399 MikeMcC399 self-assigned this May 29, 2024
@MikeMcC399 MikeMcC399 force-pushed the fix/contributing-links branch 2 times, most recently from 0926415 to a921cdc Compare May 29, 2024 08:57
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 force-pushed the fix/contributing-links branch from a921cdc to dfdc7d5 Compare May 29, 2024 09:12
@MikeMcC399 MikeMcC399 force-pushed the fix/contributing-links branch from dfdc7d5 to 63eaa37 Compare May 29, 2024 11:59
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 29, 2024 12:11
@jennifer-shehane jennifer-shehane merged commit 45330f6 into cypress-io:master May 29, 2024
31 checks passed
@MikeMcC399 MikeMcC399 deleted the fix/contributing-links branch May 30, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants