Skip to content

docs: remove included/readme image generation instructions #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The included/README > Building and testing section includes outdated instructions to build a new image using the removed script add:included. The instructions appear to be targeted to contributors, as they describe pushing to Cypress' Docker Hub.

Background

Change

Completely remove the outdated and misplaced section included/README > Building and testing.

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 27, 2024 07:51
@MikeMcC399 MikeMcC399 self-assigned this May 27, 2024
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@jennifer-shehane jennifer-shehane merged commit 4dcdb89 into cypress-io:master May 27, 2024
33 checks passed
@MikeMcC399 MikeMcC399 deleted the included-generation branch May 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants