Skip to content

chore: remove obsolete compose v1 file format version #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The repo uses an obsolete version file format definition in Docker compose files:

Docker Compose outputs the following warning message when run:

version is obsolete

Background

The version definition belongs to the Compose V1 specification and is no longer supported. Compose V1 is no longer included in current releases of Docker Desktop and the final release was in May 2021.

Compose V2, the current version, released in 2020, ignores the version top-level element in the compose.yml file. See Compose history and Version top-level element (obsolete).

Change

Remove the obsolete version: file format definition from

Verification

On Ubunu 22.04.4 LTS, Node.js v20.13.1 LTS

Execute:

cd factory
docker compose build factory
docker compose build

and confirm that all images are built without errors or warnings. Continue with

cd test-project
set -a && . ../.env && set +a
docker compose run test-base

and confirm that the image builds without errors or warnings and runs successfully.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 19, 2024 11:53
@jennifer-shehane jennifer-shehane merged commit 6d3a798 into cypress-io:master May 20, 2024
33 checks passed
@MikeMcC399 MikeMcC399 deleted the remove/compose-file-version branch May 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants