Skip to content

Conversation

@camilevahviraki
Copy link
Contributor

@camilevahviraki camilevahviraki commented Sep 6, 2025

🍰 Pullrequest

This PR introduces several improvements to the UX of Sieve filters in Cypht to make rule creation and management more intuitive and user-friendly.

Improvements

  • Added a conditional match type dropdown (ALL / ANY) when multiple conditions are defined
  • Improved layout of condition rows for clarity
  • General code cleanup and minor UI consistency fixes.

Issues

Example

Screencast.from.2025-09-19.14-06-55.webm

@camilevahviraki camilevahviraki changed the title [ENH] Show sieve filter match type dropdown conditionnaly (refactor) Show sieve filter match type dropdown conditionnaly Sep 6, 2025
@camilevahviraki camilevahviraki changed the title (refactor) Show sieve filter match type dropdown conditionnaly refactor: Show sieve filter match type dropdown conditionnaly Sep 6, 2025
@camilevahviraki camilevahviraki changed the title refactor: Show sieve filter match type dropdown conditionnaly refactor(sieve filter): Show sieve filter match type dropdown conditionnaly Sep 6, 2025
@camilevahviraki camilevahviraki marked this pull request as draft September 6, 2025 10:07
@camilevahviraki camilevahviraki changed the title refactor(sieve filter): Show sieve filter match type dropdown conditionnaly refactor(sieveFilters): Show sieve filter match type dropdown conditionnaly Sep 6, 2025
@camilevahviraki camilevahviraki changed the title refactor(sieveFilters): Show sieve filter match type dropdown conditionnaly refactor(sieveFilters): Show sieve filter UX by making things more conditinnal Sep 6, 2025
@camilevahviraki camilevahviraki changed the title refactor(sieveFilters): Show sieve filter UX by making things more conditinnal refactor(module/sievefilters): Show sieve filter UX by making things more conditinnal Sep 6, 2025
@camilevahviraki camilevahviraki changed the title refactor(module/sievefilters): Show sieve filter UX by making things more conditinnal refactor(module/sievefilters): show sieve filter UX by making things more conditinnal Sep 6, 2025
@camilevahviraki camilevahviraki force-pushed the enh/sieve-filter-ux branch 3 times, most recently from 5dab02f to d3a8e87 Compare September 6, 2025 20:47
@marclaporte
Copy link
Member

@camilevahviraki Any change you could come to the next Cypht community meeting to present your progress? https://github.com/cypht-org/cypht/wiki/Monthly-Community-Meetings

I'd like to know what @cptsanifair thinks given his suggestion here: #1308

@camilevahviraki
Copy link
Contributor Author

@camilevahviraki Any change you could come to the next Cypht community meeting to present your progress? https://github.com/cypht-org/cypht/wiki/Monthly-Community-Meetings

I'd like to know what @cptsanifair thinks given his suggestion here: #1308

Thanks for the invitation @marclaporte !
I’d be happy to join the next Cypht community meeting and present the progress I’ve made so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants