-
Notifications
You must be signed in to change notification settings - Fork 80
feat: add paper wallet functionality #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add paper wallet functionality #1141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See notes:
- scanning should respect user's Tor preferences and use Tor if enabled and connected,
- scanning should respect user's node preferences and use preferred nodes other than the default if selected,
- the wallet is swept without confirmation from the user. no txs should be made nor wallets deleted without user confirmation,
- the loading indicator should match the widgets and pattern used elsewhere in the app
lib/pages/add_wallet_views/add_wallet_view/add_wallet_view.dart
Outdated
Show resolved
Hide resolved
@sneurlax may have covered some of these points:
|
Added a dialog box for both mnemonic display and verify for the new wallet. Fixed other things as Tor, node choice and loading screen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm probably missing some things as its been a long day
lib/pages/add_wallet_views/add_wallet_view/add_wallet_view.dart
Outdated
Show resolved
Hide resolved
lib/pages/add_wallet_views/add_wallet_view/add_wallet_view.dart
Outdated
Show resolved
Hide resolved
uses app-wide flushbar refactors scanner as the latest removes unused logging
Moved the logic to a standalone function until wallet creation service is implemented. |
@julian-CStack @sneurlax Sorry for ping. |
While there have been improvements since the opening of this PR, the UX is still not great. The lack of error/failure messages and processing happening without indication in the UI as well as inconsistent mnemonic verification (ui and flow) and wallet creation flow still requires some work. So for now I will merge this into a separate branch until we have time to go over it again. You are welcome to continue working on it and create another PR with changes to https://github.com/cypherstack/stack_wallet/tree/paper-wallet-import |
txid
is provided.