Support failure domains for NodeImageSet creation #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroalphat
force-pushed
the
improve-scheduling
branch
from
050f808 to
eaf8eea
Compare
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
zeroalphat
force-pushed
the
improve-scheduling
branch
from
eaf8eea to
535b76c
Compare
masa213f
requested changes
Sep 17, 2025
Comment on lines
246
to
248
| if zone == "" { | ||
| zone = constants.NoZoneName | ||
| } |
There was a problem hiding this comment.
Is it necessary to use constants.NoZoneName?
It's no problem to leave the zone as an empty string.
Using constants.NoZoneName, it just creates unnecessary constraints.
There was a problem hiding this comment.
This process wasn't really necessary, so I removed it.
| if zone == "" { | ||
| zone = constants.NoZoneName | ||
| } | ||
| zoneScore := constants.MaxZoneScore - zoneCount[zone] |
There was a problem hiding this comment.
It's fine as is, but constants.MaxZoneScore may have no meaning.
This constant does not affect the sort order.
There was a problem hiding this comment.
I was using the MaxZoneScore variable to invert the score. However, there wasn't much point in inverting it, so I removed the variable and the related logic.
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13