Skip to content

Conversation

@Till0196
Copy link
Contributor

This PR adds cross-platform support for downloading the yq binary in the Makefile,
replacing the hardcoded Linux AMD64 version.

Changes

  • Add dynamic OS and architecture detection using uname commands
  • Replace hardcoded yq_linux_amd64 download with parameterized yq_$(OS)_$(ARCH)
  • Update tar extraction and file moving to use dynamic filenames (added mv command for BSD tar compatibility)
  • Support macOS (darwin), Linux, and multiple architectures (AMD64, ARM64)

Benefits

  • Enables development on macOS and ARM-based systems
  • Removes platform-specific hardcoding
  • Improves developer experience across different environments

@chez-shanpu chez-shanpu self-requested a review August 26, 2025 05:20
Copy link
Contributor

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chez-shanpu chez-shanpu merged commit 4cc9638 into cybozu-go:main Aug 26, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants