Skip to content

Conversation

@Till0196
Copy link
Contributor

What

Add multi-platform support for e2e test binary downloads in Makefile

Why

The current implementation only supports Linux amd64, preventing developers on macOS or ARM64 architectures from running e2e tests locally.

How

  • Detect OS and architecture automatically
  • Download appropriate binaries based on the detected platform
  • Support Linux/macOS on both amd64/arm64

chez-shanpu
chez-shanpu previously approved these changes Aug 21, 2025
Copy link
Contributor

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chez-shanpu chez-shanpu merged commit f400c1c into cybozu-go:main Aug 22, 2025
29 checks passed
@Till0196 Till0196 deleted the support-e2e-mac branch August 26, 2025 00:22
@Till0196 Till0196 restored the support-e2e-mac branch August 26, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants