DualStack support for egress #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-strusiewiczsurmacki-mobica
force-pushed
the
dualstack-egress
branch
from
7f05792 to
0262d66
Compare
terassyi
reviewed
May 9, 2025
v2/controllers/egress_watcher.go
Outdated
| } | ||
|
|
||
| func (r *EgressWatcher) getHook(ctx context.Context, eg *coilv2.Egress, logger *logr.Logger) (nodenet.SetupHook, error) { | ||
| func (r *EgressWatcher) getHook(ctx context.Context, eg *coilv2.Egress, logger *logr.Logger) ([]nodenet.SetupHook, error) { |
There was a problem hiding this comment.
Now, this function returns multiple hooks, so let's rename it.
Suggested change
| func (r *EgressWatcher) getHook(ctx context.Context, eg *coilv2.Egress, logger *logr.Logger) ([]nodenet.SetupHook, error) { | |
| func (r *EgressWatcher) getHooks(ctx context.Context, eg *coilv2.Egress, logger *logr.Logger) ([]nodenet.SetupHook, error) { |
There was a problem hiding this comment.
Done :)
|
Almost all of your changes look good to me! |
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk.pawel.strusiewicz-surmacki@external.telekom.de>
p-strusiewiczsurmacki-mobica
force-pushed
the
dualstack-egress
branch
from
0262d66 to
a922fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for dualstack egress.
Egress service reconciler will create egress services with
PreferDualstackIP family policy.Hook generation will now use
svc.Spec.ClusterIPsinstead ofsvc.Spec.ClusterIPwhich will make this incompatible with k8s older that1.20.E2E tests were added and CI updated to reflect the changes.