Skip to content

Conversation

@chez-shanpu
Copy link
Contributor

@chez-shanpu chez-shanpu commented Apr 18, 2025

Some tests are expected to be tested in the order they are written, but the order of execution of It() is not determined.
Therefore order-sensitive tests was failing flaky.
e.g. https://github.com/cybozu-go/coil/actions/runs/14495849428/job/40663286944?pr=324

This PR add Ordered decoration to order-sensitive tests.

@chez-shanpu chez-shanpu requested a review from terassyi April 18, 2025 01:41
@chez-shanpu chez-shanpu force-pushed the e2e-ordered branch 2 times, most recently from f791dfe to 89ed053 Compare April 18, 2025 01:52
Signed-off-by: Tomoki Sugiura <tomoki-sugiura@cybozu.co.jp>
Copy link
Contributor

@terassyi terassyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chez-shanpu chez-shanpu merged commit 89546ff into main Apr 18, 2025
17 checks passed
@chez-shanpu chez-shanpu deleted the e2e-ordered branch April 18, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants