Fix controller names #314
Merged
Fix controller names #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terassyi
force-pushed
the
fix-controller-name
branch
from
5b1574d to
b9999ab
Compare
chez-shanpu
reviewed
Mar 3, 2025
v2/e2e/kustomization.yaml
Outdated
Comment on lines
2
to
3
| - ../config/default | ||
| - ../config/pod/coil-router.yaml |
There was a problem hiding this comment.
Suggested change
| - ../config/default | |
| - ../config/pod/coil-router.yaml | |
| - ../config/default | |
| - ../config/pod/coil-router.yaml |
nit: Other yaml files don't have spaces.
There was a problem hiding this comment.
my editor added spaces automatically.
I fixed this.
terassyi
force-pushed
the
fix-controller-name
branch
from
b9999ab to
4fb56f2
Compare
Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp>
terassyi
force-pushed
the
fix-controller-name
branch
from
4fb56f2 to
57e1a19
Compare
chez-shanpu
reviewed
Mar 4, 2025
Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp>
terassyi
force-pushed
the
fix-controller-name
branch
from
f6e75e6 to
4052da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: terashima tomoya-terashima@cybozu.co.jp