allows for non-editable build #9
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows for non-editable build: `pip install .`
|
Actually, this is enough for the package, but not data and config files, let me update them as well |
|
Hey thanks! Is this still working in progress? |
|
Yes. It actually requires much more work than I thought, because many weights loading and import operations relies on the editable install - and not only limap, but submodules as well... |
zhangshaos
pushed a commit
to zhangshaos/limap
that referenced
this pull request
Jul 12, 2023
* endpoints triangulation as an option. port output folder. * fix depth-based scoring for endpoints triangulation. * bind essential and fundamental matrix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.