Fully test on Windows #894
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
fully-test-on-windows
branch
2 times, most recently
from
b9626b5 to
78b85dc
Compare
mvz
force-pushed
the
fully-test-on-windows
branch
from
78b85dc to
8546717
Compare
mvz
force-pushed
the
fully-test-on-windows
branch
5 times, most recently
from
d0858f2 to
1460be7
Compare
* Use existing commands instead of non-portable bash scripts * Use timeout command if sleep is not available
- Do not use bash scripts - Directly run echo or ruby where possible - Move large output edge case to spec
- Move scenarios for checking success + output to a separate feature - Unify order and implementation of scenarios for checking output, stderr and stdout
mvz
force-pushed
the
fully-test-on-windows
branch
from
3a8d59a to
1525fdc
Compare
This change ensures no errors were reported, and that both checks are performed before reporting any failures.
mvz
force-pushed
the
fully-test-on-windows
branch
from
d8284a0 to
74971f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Run Cucumber suite on Windows as well and make it pass
Details
This is a reprise of #505, #619, #799, and #817. I'm opening a new pull request to be able to base it on #892 and make the minimal changes needed.
Motivation and Context
If we want to say Aruba supports Windows, we should at least have the full test suite run on Windows in CI.
How Has This Been Tested?
CI will tell us where we stand
Types of changes
Checklist: